Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LocalizedMultilineTextField #132

Merged
merged 2 commits into from
Oct 5, 2018
Merged

Add LocalizedMultilineTextField #132

merged 2 commits into from
Oct 5, 2018

Conversation

dferber90
Copy link
Contributor

@dferber90 dferber90 commented Oct 4, 2018 •
edited
Loading

Add LocalizedMultilineTextField.

@dferber90 dferber90 requested a review from lufego October 4, 2018 10:01
@dferber90 dferber90 force-pushed the df-add-localized-multiline-text-field branch from f1f2f5b to 62e56ad Compare October 4, 2018 10:22
@dferber90 dferber90 changed the title Add LocalizedMultilineTextInput Add LocalizedMultilineTextField Oct 5, 2018
@dferber90 dferber90 added the 👨‍🎨 Status: UI/UX Review Requires review from design team label Oct 5, 2018
Shecki
Shecki approved these changes Oct 5, 2018
View reviewed changes
Copy link

@Shecki Shecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved from UX side

@dferber90 dferber90 force-pushed the df-add-localized-multiline-text-field branch from 62e56ad to fbda5cd Compare October 5, 2018 10:21
@dferber90 dferber90 merged commit 5e0bdff into master Oct 5, 2018
@dferber90 dferber90 deleted the df-add-localized-multiline-text-field branch October 5, 2018 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shecki Shecki Shecki approved these changes

@lufego lufego Awaiting requested review from lufego

Assignees
No one assigned
Labels
👨‍🎨 Status: UI/UX Review Requires review from design team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dferber90 @Shecki