fix(data-table): move wrapHeaderLabel to become a table prop #1309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The setting becomes general for the whole table, instead of per-column.
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/commercetools/ui-kit/lec3yrxm9 |
tdeekens
approved these changes
Apr 1, 2020
jonnybel
force-pushed
the
ja-table-nowrap-all-columns
branch
from
7238ff9 to
3a224c8
Compare
jonnybel
force-pushed
the
ja-table-nowrap-all-columns
branch
from
3a224c8 to
7b3b9b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The setting added in #1305 becomes general for the whole table, instead of per-column.
Why?
If one column header breaks into several lines, it will increase the height for all other columns as well, so it makes more sense for the setting to be general: either all cells keep their default height, or they can all use the available vertical space.
Also, it's easier to enable the option using a single prop instead of having to set the property for every individual column.