fix(data-table): return sortDirection in onSortChange #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/commercetools/ui-kit/6pafsl7ce |
tdeekens
reviewed
Mar 26, 2020
tdeekens
approved these changes
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adjusts the
DataTableto have theonSortChangefn use the nextsortDirectionin its interface.Description
This is useful for situations (which already exist in the MC) where the sorting isn't done in the client-side with the
useSortinghook, but is instead performed by the server and we're letting the table internally control and provide thesortDirectionto the consumer.I'm marking this as a fix because the old table already provides this interface, and while I initially thought it unnecessary, I found it useful for easing the migration from the old table to the new one.