Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UKIT-97] fix(tag): on remove button hover when disabled #1253

Merged
merged 1 commit into from
Jan 29, 2020

Conversation

jonnybel
Copy link
Contributor

Summary

Fix for UKIT-97

When the user hovers the removable area on a disabled label, the button still displays the orange hover effect that indicates the label is removable. There should not display any hover effect when disabled.

@jonnybel jonnybel added the 🐛 Type: Bug Something isn't working label Jan 29, 2020
@jonnybel jonnybel self-assigned this Jan 29, 2020
@vercel
Copy link

vercel bot commented Jan 29, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/commercetools/ui-kit/6jd2g7uk7
✅ Preview: https://ui-kit-git-ja-fix-tag-remove-btn-when-disabled.commercetools.now.sh

&:hover,
&:focus {
:not(:disabled)&:hover,
:not(:disabled)&:focus {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How dare you use css for this!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it can be done with CSS, I will do it with CSS 😎

@jonnybel jonnybel changed the title fix(tag): on remove button hover when disabled [UKIT-97] fix(tag): on remove button hover when disabled Jan 29, 2020
@kodiakhq kodiakhq bot merged commit de3711a into master Jan 29, 2020
@kodiakhq kodiakhq bot deleted the ja-fix-tag-remove-btn-when-disabled branch January 29, 2020 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants