Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(secondary-button): to prop-type #1251

Merged
merged 2 commits into from
Jan 27, 2020
Merged

Conversation

tdeekens
Copy link
Contributor

Summary

This pull request intends to clear up some confusion about the to prop-type.

Description

The linkTo-prop was recently being deprecated. In favour of using the as-prop with a paring of the to-prop. However, the linkTo prop either accepted a string of an object of { pathname, search, query } for the underlying react-router. The to-prop doesn't support this. This overall makes migrating to the to prop in internal apps not possible as far as I can tell. As a result I propose to accept the same shape on the to prop and forward it.

@vercel
Copy link

vercel bot commented Jan 27, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/commercetools/ui-kit/ffwt113p4
✅ Preview: https://ui-kit-git-fix-secondary-button-prop-types.commercetools.now.sh

@tdeekens tdeekens requested review from emmenko and jonnybel January 27, 2020 08:26
@tdeekens tdeekens self-assigned this Jan 27, 2020
@tdeekens tdeekens added 🐛 Type: Bug Something isn't working 🙏 Status: Dev Review Waiting for technical reviews labels Jan 27, 2020
@tdeekens
Copy link
Contributor Author

Note, that this "blocks" a non-urgent internal PR. I would also silence the console there dependening on when the next release is planned 😸.

Copy link
Contributor

@jonnybel jonnybel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@kodiakhq kodiakhq bot merged commit d028c2c into master Jan 27, 2020
@kodiakhq kodiakhq bot deleted the fix/secondary-button-prop-types branch January 27, 2020 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙏 Status: Dev Review Waiting for technical reviews 🐛 Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants