Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: regenerate icon exports #1234

Merged
merged 1 commit into from
Jan 7, 2020
Merged

chore: regenerate icon exports #1234

merged 1 commit into from
Jan 7, 2020

Conversation

jonnybel
Copy link
Contributor

@jonnybel jonnybel commented Jan 7, 2020

Summary

The generate-icon-exports.js now generates a different output for our icons/raw-components and should be updated, otherwise, it results in changes every time we run yarn start.

This is due to the latest major update of svgr (done in #1226).

Relevant change (in their release log: https://github.com/gregberge/svgr/releases/v5.0.0):

use new default template with function (gregberge/svgr@86e0723)

@jonnybel jonnybel self-assigned this Jan 7, 2020
@vercel
Copy link

vercel bot commented Jan 7, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/commercetools/ui-kit/5fjwqhafn
✅ Preview: https://ui-kit-git-ja-generate-icon-exports.commercetools.now.sh

Copy link
Member

@emmenko emmenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@kodiakhq kodiakhq bot merged commit 75f4769 into master Jan 7, 2020
@kodiakhq kodiakhq bot deleted the ja-generate-icon-exports branch January 7, 2020 11:43
jonnybel added a commit that referenced this pull request Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants