Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AsyncCreatableSelectInput: explicitly declare props #122

Merged
merged 1 commit into from
Oct 2, 2018
Merged

AsyncCreatableSelectInput: explicitly declare props #122

merged 1 commit into from
Oct 2, 2018

Conversation

dferber90
Copy link
Contributor

@dferber90 dferber90 commented Oct 2, 2018 •
edited
Loading

  • move AsyncCreatableSelectInput out of beta
  • explicitly declare props
  • adapt docs and spec

Same as #119 but for AsyncCreatableSelectInput.

@dferber90 dferber90 requested review from pa3, islam3zzat and lufego October 2, 2018 08:02
@dferber90 dferber90 force-pushed the df-explicitly-delcare-react-select-props branch from cd1eda4 to ac0ddea Compare October 2, 2018 09:47
@dferber90 dferber90 changed the base branch from df-explicitly-delcare-react-select-props to master October 2, 2018 10:06
@dferber90 dferber90 force-pushed the df-explicitly-delcare-react-select-props-async-creatable branch from 8e5ac03 to 81a7bb7 Compare October 2, 2018 10:08
@dferber90 dferber90 merged commit 8e9b43e into master Oct 2, 2018
@dferber90 dferber90 deleted the df-explicitly-delcare-react-select-props-async-creatable branch October 2, 2018 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lufego lufego lufego left review comments

@tdeekens tdeekens tdeekens approved these changes

@pa3 pa3 Awaiting requested review from pa3

@islam3zzat islam3zzat Awaiting requested review from islam3zzat

Assignees
No one assigned
Labels
💅 Type: Enhancement Improves existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dferber90 @tdeekens @lufego