fix(text-detail): proptypes warning when providing an empty string as… #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… children to TextDetail component
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/commercetools/ui-kit/86kiuaabg |
jonnybel
reviewed
Dec 10, 2019
tdeekens
approved these changes
Dec 10, 2019
|
@jonnybel Yes, I will do the changes for other components as well 👍 . |
kodiakhq
bot
deleted the
am-fix-TextDetail-proptypes-warning-when-empty-string-as-children
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… children to TextDetail component
Summary
A PropTypes warning will be thrown when providing an empty string as the children of
Text.Detailcomponent.Description
The bug is caused by the empty string being coerced to
false, this PR fixes it by counting the children instead.Fixes #1212