Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CreatableSelectInput: explicitly declare props #121

Merged
merged 1 commit into from
Oct 2, 2018
Merged

CreatableSelectInput: explicitly declare props #121

merged 1 commit into from
Oct 2, 2018

Conversation

dferber90
Copy link
Contributor

  • Explicitly declares props of CreatableSelectInput
  • Moves CreatableSelectInput out of beta
  • Adapts story and README

@dferber90 dferber90 requested review from pa3, islam3zzat and lufego October 2, 2018 07:33
adnasa
adnasa reviewed Oct 2, 2018
View reviewed changes
Copy link
Contributor

@adnasa adnasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a question

@dferber90 dferber90 force-pushed the df-explicitly-delcare-react-select-props branch from cd1eda4 to ac0ddea Compare October 2, 2018 09:47
@dferber90 dferber90 changed the base branch from df-explicitly-delcare-react-select-props to master October 2, 2018 10:01
@dferber90 dferber90 force-pushed the df-explicitly-delcare-react-select-props-creatable branch from 796a506 to 63ab8cd Compare October 2, 2018 10:03
@dferber90 dferber90 merged commit 37e607f into master Oct 2, 2018
@dferber90 dferber90 deleted the df-explicitly-delcare-react-select-props-creatable branch October 2, 2018 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adnasa adnasa adnasa left review comments

@tdeekens tdeekens tdeekens approved these changes

@lufego lufego lufego approved these changes

@pa3 pa3 Awaiting requested review from pa3

@islam3zzat islam3zzat Awaiting requested review from islam3zzat

Assignees
No one assigned
Labels
💅 Type: Enhancement Improves existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dferber90 @adnasa @tdeekens @lufego