fix(tooltip): do not use native title when tooltip is off #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmenko
reviewed
Nov 25, 2019
Co-Authored-By: Nicola Molinari <[email protected]>
emmenko
reviewed
Nov 25, 2019
| // should not remove title | ||
| expect(button).toHaveProperty('title', 'What kind of bear is best?'); | ||
| // should not have title | ||
| expect(button).not.toHaveProperty('title', 'What kind of bear is best?'); |
There was a problem hiding this comment.
Suggested change
| expect(button).not.toHaveProperty('title', 'What kind of bear is best?'); | |
| expect(button).not.toHaveAttribute('title'); |
this one as well 😅
tdeekens
approved these changes
Nov 25, 2019
jonnybel
approved these changes
Nov 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When
Tooltipis set to off, we should not addaria-describedbyortitle.