feat(select): add isReadOnly prop to select inputs and fields #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdeekens
reviewed
Nov 21, 2019
src/components/inputs/async-creatable-select-input/async-creatable-select-input.js
Show resolved
Hide resolved
jonnybel
commented
Nov 21, 2019
Comment on lines
+50
to
+51
| isDisabled: props.isDisabled, | ||
| isReadOnly: props.isReadOnly, |
There was a problem hiding this comment.
We're now also passing the isDisabled prop because we will use it for the styles instead of the internal state.isDisabled, to differentiate between isDisabled and isReadOnly.
tdeekens
approved these changes
Nov 21, 2019
jonnybel
commented
Nov 21, 2019
montezume
approved these changes
Nov 25, 2019
montezume
force-pushed
the
ja-select-input-readonly
branch
from
ff5cd6e to
e715dec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the
isReadOnlyprop to ourSelectInput.It also adds the same prop to
AsyncSelectInput,CreatableSelectInputandAsyncCreatableSelectInput.And then also to their 4 corresponding
*SelectFieldcomponents.There's a lot changes because it's the same change in 8 different components, but the focus of the review can be on only one of them and on the
create-select-styles, which is shared across all of them.Description
react-selectdoesn't supportisReadOnlybecause it doesn't have any functional difference fromisDisabled, it's only a matter of styling it differently. So basically I'm disabling it internally and giving it the sameread-onlyvisuals as we have for the other inputs.But the main point of adding the prop is because almost all of our inputs support
readOnlyand users of the library may erroneously expect it for this component as well, as it happened here. So it's a matter of consistency.