Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(typography): fix Text.Body to use intlMessage when 'as' prop is present #1122

Merged
merged 3 commits into from
Oct 22, 2019
Merged

fix(typography): fix Text.Body to use intlMessage when 'as' prop is present #1122

merged 3 commits into from
Oct 22, 2019

Conversation

jonnybel
Copy link
Contributor

Fixes a bug where intlMessage prop is being ignored when the as prop is present for the Text.Body component.

@jonnybel jonnybel added 🐛 Type: Bug Something isn't working Semver: FIX labels Oct 22, 2019
@jonnybel jonnybel self-assigned this Oct 22, 2019
jonnybel
jonnybel commented Oct 22, 2019
View reviewed changes
src/components/typography/text/text.js Outdated
Comment on lines 183 to 187
{props.intlMessage ? (
<FormattedMessage {...props.intlMessage} />
) : (
props.children
)}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was missing.

@jonnybel jonnybel requested a review from montezume October 22, 2019 09:04
@montezume
Copy link
Contributor

Can you add a test?

emmenko
emmenko approved these changes Oct 22, 2019
View reviewed changes
Copy link
Member

@emmenko emmenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@kodiakhq kodiakhq bot merged commit f1fdf62 into master Oct 22, 2019
@kodiakhq kodiakhq bot deleted the ja-text-fix-body-intl-message branch October 22, 2019 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmenko emmenko emmenko approved these changes

@montezume montezume montezume approved these changes

Assignees

@jonnybel jonnybel

Labels
🐛 Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonnybel @montezume @emmenko