UI-KIT-37: Tags styling issue when dropdown isMulti #112
+18
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lufego
changed the title
lufego
added
🐛 Type: Bug
dferber90
approved these changes
Oct 1, 2018
| ========================================================================== */ | ||
|
|
||
| /* Height */ | ||
| --token-size-height-tags: 26px; |
There was a problem hiding this comment.
We have --token-size-height-input with input being singular.
We now add --token-size-height-tags with tags being plural.
We seem to use --token-border-radius-tags in plural as well though.
Can you elaborate why you went for plural for tags but singular for inputs?
There was a problem hiding this comment.
I knew this was coming 😅 but since this was already created before, I just followed the patterns. I'll make a following PR with a rename of the tags to tag \
Thanks for pointing this out 👍
tdeekens
approved these changes
Oct 1, 2018
adnasa
approved these changes
Oct 1, 2018
dferber90
force-pushed
the
ui-kit-37-tag-issue
branch
from
f36a9c5 to
342d939
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When adding isMulti to the dropdowns, the component was getting a bigger height.
Now we have:
isMultimodeDescription
Before
After
With multi options (after)
