Fix lost updates of MoneyInput for Formik validation #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dferber90
force-pushed
the
df-fix-money-input-formik-2
branch
from
3c57e3e to
7635b6f
Compare
tdeekens
approved these changes
Sep 28, 2018
|
Should we have issues on the repo? Like Tech Debt ones or something? The code comments are awesome but I fear us forgetting about them... |
|
Tracking it in #109 now 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validation was still being called with invalid values in case the user enters a perfectly formatted amount before selecting a currency.
This workaround can also be removed once jaredpalmer/formik#939 is released.