Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix money input tooltip #1029

Merged
merged 3 commits into from
Aug 26, 2019
Merged

chore: fix money input tooltip #1029

merged 3 commits into from
Aug 26, 2019

Conversation

montezume
Copy link
Contributor

@montezume montezume commented Aug 26, 2019

Summary

Fixes bug with MoneyInput and the tooltip

Before
image (10)

After

this is it

@montezume montezume self-assigned this Aug 26, 2019
@montezume montezume added the 🐛 Type: Bug Something isn't working label Aug 26, 2019
@montezume montezume requested review from jonnybel and tdeekens August 26, 2019 13:54
WrapperComponent: TooltipWrapper,
}}
<React.Fragment>
<div id={`portal-${props.id}`} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: getPortalId and getPortalNode.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kodiakhq kodiakhq bot merged commit 5ccadf8 into master Aug 26, 2019
@kodiakhq kodiakhq bot deleted the ml-cutofftooltip branch August 26, 2019 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants