-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spacings component support option for space-between
layout configuration
#552
Comments
I think we have two options:
I think it should be enough to go with the first approach. |
Does it mean that if we pass WDYT? 🤔 |
The |
Is this issue maybe relevant? https://github.com/commercetools/merchant-center-frontend/issues/4786 |
I think that issue should be solved with a css-grid |
Problem
Currently we have a bunch of files in the MC that use custom style for the layout configuration of
space-between
. I'm thinking that if that is a common case for styling UI maybe we can add it to UI-Kit 😋Proposal
The solution would be to just extends our
Spacings
component to support this option or maybe just add a new section calledLayouts
even though I think it makes more sense to add it toSpacings
.@emmenko already introduced some code in which we can get some inspiration from 👍
https://github.com/commercetools/merchant-center-application-kit/blob/011e07d2855c40b0c9d7b40ff463f467f6336362/packages/application-components/src/components/dialogs/info-dialog/info-dialog.js#L14-L20
The idea could be
Spacings.Between
orSpacings.Stretched
with a configuration for thealignItems
that by default would be centered. That is up to discussion 🐤I see only benefits from this:
Additional context
Asked by Malcolm in commercetools/merchant-center-application-kit#367 (comment) 🤓
The text was updated successfully, but these errors were encountered: