Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved: better frontend package installation guide #7047

Conversation

ltdrdata
Copy link
Collaborator

@ltdrdata ltdrdata commented Mar 3, 2025

improved: better installation guide

  • change pip to {sys.executable} -m pip

modified: To prevent the guide message from being obscured by a complex error message, apply exit instead of raise.

- change `pip` to `{sys.executable} -m pip`
modified: To prevent the guide message from being obscured by a complex error message, apply `exit` instead of `raise`.
@comfyanonymous comfyanonymous merged commit d6e5d48 into comfyanonymous:master Mar 3, 2025
5 checks passed
@ltdrdata ltdrdata deleted the improve/better_missing_front_log branch March 3, 2025 09:49
@mcmonkey4eva
Copy link
Contributor

This is wrong: it should be -s -m pip

The -s is critical, otherwise a venv will potentially pollute links to global python

ltdrdata added a commit to ltdrdata/ComfyUI that referenced this pull request Mar 6, 2025
`{sys.executable} -m pip`
-> `{sys.executable} -s -m pip`

comfyanonymous#7047 (comment)
ltdrdata added a commit to ltdrdata/ComfyUI that referenced this pull request Mar 6, 2025
`{sys.executable} -m pip` -> `{sys.executable} -s -m pip`

comfyanonymous#7047 (comment)
comfyanonymous pushed a commit that referenced this pull request Mar 6, 2025
`{sys.executable} -m pip` -> `{sys.executable} -s -m pip`

#7047 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants