Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --packages-above-depth selection mechanism #22

Merged
merged 3 commits into from
Mar 18, 2019
Merged

Add --packages-above-depth selection mechanism #22

merged 3 commits into from
Mar 18, 2019

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Mar 14, 2019

This package selection argument selects the given packages and packages which depend on them, proceeding out to the given depth.

Passing a depth of 0 yields the same behavior as --packages-select, while passign a sufficiently large value yeilds the same behavior as --packages-above.

Requires colcon/colcon-core#172

Inspired by ros-infrastructure/ros_buildfarm#590 (comment)

...I would lean toward a new separate argument --packages-above-depth N PKG_NAME(s) (only usable once for now).

@cottsay cottsay added enhancement New feature or request review Waiting for review (Kanban column) labels Mar 14, 2019
@cottsay cottsay self-assigned this Mar 14, 2019
@cottsay cottsay requested a review from dirk-thomas March 14, 2019 21:44
cottsay and others added 2 commits March 18, 2019 12:40
This package selection argument selects the given packages and packages
which depend on them, proceeding out to the given depth.

Passing a depth of `0` yields the same behavior as `--packages-select`,
while passign a sufficiently large value yeilds the same behavior as
`--packages-above`.
Copy link
Member

@dirk-thomas dirk-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also set the minimum version dependency on colcon-core in the setup.cfg file.

@dirk-thomas
Copy link
Member

Thanks for the improvement.

@dirk-thomas dirk-thomas added this to the 0.2.4 milestone Mar 18, 2019
@dirk-thomas dirk-thomas merged commit c53a320 into colcon:master Mar 18, 2019
@dirk-thomas dirk-thomas removed the review Waiting for review (Kanban column) label Mar 18, 2019
@cottsay cottsay deleted the packages_above_depth branch March 18, 2019 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants