Feat/getPriceQuote #2065
Merged
Feat/getPriceQuote #2065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschlabach
reviewed
Mar 4, 2025
dschlabach
reviewed
Mar 4, 2025
Comment on lines
+53
to
+54
| error: 'Invalid input: tokens must be an array of at least one token', | ||
| message: '', |
There was a problem hiding this comment.
May be useful to have tokens must be an array of at least one token in the message ?
There was a problem hiding this comment.
good call, adding
dschlabach
approved these changes
Mar 4, 2025
Comment on lines
+398
to
+409
| type PriceQuote = { | ||
| /** The name of the token */ | ||
| name: string | ''; | ||
| /** The symbol of the token */ | ||
| symbol: string | ''; | ||
| /** The contract address of the token */ | ||
| contractAddress: Address | ''; | ||
| /** The price of the token */ | ||
| price: string | ''; | ||
| /** The timestamp of the price quote */ | ||
| timestamp: number | 0; | ||
| }; |
There was a problem hiding this comment.
Out of curiosity why the ''?
There was a problem hiding this comment.
I haven't been able to discern the pattern, but sometimes the API doesn't return all the fields.
I don't think this is a problem, because it has so far always returned the contractAddress, and the caller should have all the other info.
There was a problem hiding this comment.
wouldn't '' be covered under string?
There was a problem hiding this comment.
@alessey ah, you're right, i can remove those nullish versions of the types. will handle in a follow-up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
getPriceQuotegetPriceQuotefetches price quotes for the provided token contract addresses and/or ETHgetPriceQuoteis available only on Base mainnetgetPriceQuoteinterfaceRequest
Response
Usage
Notes to reviewers
How has it been tested?