chore(marketplace): notify sales when duration, minPricePerBytePerSecond or totalCollateral is updated #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emizzle
reviewed
Mar 10, 2025
Comment on lines
+308
to
+319
| if OnAvailabilitySaved =? self.OnAvailabilitySaved: | ||
| # when chronos v4 is implemented, and OnAvailabilitySaved is annotated | ||
| # with async:(raises:[]), we can remove this try/catch as we know, with | ||
| # certainty, that nothing will be raised | ||
| try: | ||
| await onAvailabilityAdded(obj) | ||
| await OnAvailabilitySaved(obj) | ||
| except CancelledError as e: | ||
| raise e | ||
| except CatchableError as e: | ||
| # we don't have any insight into types of exceptions that | ||
| # `onAvailabilityAdded` can raise because it is caller-defined | ||
| warn "Unknown error during 'onAvailabilityAdded' callback", error = e.msg | ||
| # `OnAvailabilitySaved` can raise because it is caller-defined | ||
| warn "Unknown error during 'OnAvailabilitySaved' callback", error = e.msg |
There was a problem hiding this comment.
Might be a good idea to annotate OnAvailableSaved with {.async: (raises: [].} and remove this try/except.
emizzle
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when an availability is updated,
salesis notified only when the freeSize increases.This PR changes this behavior to notify
saleswhen freeSize, duration, minPricePerBytePerSecond, or totalCollateral is increased. All those parameters are taken into consideration when trying to find an availability matching the slot.