fix: ethers no longer leaks AsyncLockError #1146
Open
+60
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2-towns
reviewed
Mar 7, 2025
codex/contracts/market.nim
Outdated
| @@ -195,7 +194,7 @@ method slotState*( | |||
| try: | |||
| let overrides = CallOverrides(blockTag: some BlockTag.pending) | |||
| return await market.contract.slotState(slotId, overrides) | |||
| except AsyncLockError as err: | |||
| except EthersError as err: | |||
There was a problem hiding this comment.
Can't we remove the except here ?
The EthersError should be caught by convertEthersError.
There was a problem hiding this comment.
I left it there because of the contextual error message. However, I've just pushed a commit that adds contextual error messages to convertEthersError and updated this block of code 👍
- adds a message to convertEthersError allowing contextual error messages - replaces try/except EthersError with convertEthersError (PR feedback)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Dependent upon codex-storage/nim-ethers#109