Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC updates [skip ci] #25

Merged
merged 1 commit into from
Jun 29, 2014
Merged

DOC updates [skip ci] #25

merged 1 commit into from
Jun 29, 2014

Conversation

sachinm
Copy link
Contributor

@sachinm sachinm commented Jun 26, 2014

updated README.md
update CONTRIBUTING.md
add docs/getting_started_on_windows.md
[skip ci]

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
updated README.md
update CONTRIBUTING.md
add docs/getting_started_on_windows.md
[skip ci]
@@ -118,51 +117,38 @@ There's only a VirtualBox basebox right now.
Now that you're SSH'ed into the Vagrant VM it's time to run the app.

# we're still SSH'ed into Vbox
cd ~/web
cd ~/assemblymade
rvm current # should be ruby-2.1.0@coderwall

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest changing this as people may be using rbenv

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rbenv isn't a supported option for me. But if it doesn't make a difference in our script I'm fine with it.

Sent from my iPhone

On Jun 28, 2014, at 12:49 PM, "Rigel St. Pierre" [email protected] wrote:

In CONTRIBUTING.md:

@@ -118,51 +117,38 @@ There's only a VirtualBox basebox right now.
Now that you're SSH'ed into the Vagrant VM it's time to run the app.

     # we're still SSH'ed into Vbox
  •    cd ~/web
    
  •    cd ~/assemblymade
     rvm current # should be ruby-2.1.0@coderwall
    
    I'd suggest changing this as people may be using rbenv


Reply to this email directly or view it on GitHub.

@akosednar
Copy link
Contributor

You may want to add a section that tells the answers to common issues.

Ex:

just3ws added a commit that referenced this pull request Jun 29, 2014
@just3ws just3ws merged commit 54fb6c1 into coderwall:master Jun 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants