Skip to content

Mark tokens as sensitive in data sources #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 30, 2025
Merged

Conversation

blink-so[bot]
Copy link
Contributor

@blink-so blink-so bot commented Jun 27, 2025

Mark the following attributes as sensitive to prevent them from being logged or displayed in Terraform output:

  • data.coder_workspace_owner.me.oidc_access_token
  • data.coder_workspace_owner.me.session_token
  • data.coder_external_auth.example.access_token

This follows the same pattern as ssh_private_key and agent token which are already marked as sensitive.

Tested with existing unit tests - all pass.

Fixes #266

blink-so bot and others added 2 commits June 27, 2025 14:14
Mark the following attributes as sensitive to prevent them from being
logged or displayed in Terraform output:

- data.coder_workspace_owner.me.oidc_access_token
- data.coder_workspace_owner.me.session_token
- data.coder_external_auth.example.access_token

This follows the same pattern as ssh_private_key and agent token
which are already marked as sensitive.

Fixes #266

Co-authored-by: matifali <[email protected]>
Regenerate documentation to reflect that oidc_access_token, session_token,
and access_token are now marked as sensitive in the schema.

Co-authored-by: matifali <[email protected]>
@matifali matifali requested review from johnstcn and kylecarbs June 27, 2025 14:25
@johnstcn johnstcn assigned johnstcn and matifali and unassigned johnstcn Jun 30, 2025
@matifali matifali merged commit f239e51 into main Jun 30, 2025
6 checks passed
@matifali matifali deleted the mark-tokens-as-sensitive branch June 30, 2025 07:41
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mark all tokens as sensitive
2 participants