Read URL and token from config #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-asher
changed the title
fioan89
reviewed
Mar 2, 2023
src/main/kotlin/com/coder/gateway/views/steps/CoderWorkspacesStepView.kt
Outdated
Show resolved
Hide resolved
fioan89
reviewed
Mar 2, 2023
src/main/kotlin/com/coder/gateway/views/steps/CoderWorkspacesStepView.kt
Show resolved
Hide resolved
code-asher
force-pushed
the
asher/background-auth
branch
from
72cb519 to
adbb653
Compare
code-asher
force-pushed
the
asher/existing-token
branch
3 times, most recently
from
7b84fba to
ec0c1ec
Compare
code-asher
commented
Mar 2, 2023
src/main/kotlin/com/coder/gateway/views/steps/CoderWorkspacesStepView.kt
Show resolved
Hide resolved
code-asher
force-pushed
the
asher/existing-token
branch
2 times, most recently
from
dc46174 to
890803a
Compare
code-asher
commented
Mar 2, 2023
| @@ -3,6 +3,8 @@ gateway.connector.description=Connects to a Coder Workspace dev environment so t | |||
| gateway.connector.action.text=Connect to Coder | |||
| gateway.connector.view.login.documentation.action=Learn more about Coder | |||
| gateway.connector.view.login.url.label=URL: | |||
| gateway.connector.view.login.existing-token.label=Use existing token | |||
| gateway.connector.view.login.existing-token.tooltip=Checking "{0}" will prevent the browser from being launched for generating a new token. Additionally, if a token is already configured for this URL via the CLI it will appear as the default and can be used as-is or replaced. | |||
There was a problem hiding this comment.
Pinging @sharkymark @bpmct @ericpaulsen in case anyone has opinions on the wording of the checkbox help text (it has been tweaked a bit since the screenshot).
In case the user has already configured the CLI. This will only happen without user input until the first successful connection. After that the "use existing token" checkbox must be used to read the token from the config. It will only be used if it matches the URL. A secondary effect of the checkbox is that it will not open the browser window so it can also be used in the case where you already have a token you want to use but it is not in the CLI config. Lastly I removed some padding in an attempt to regain the space lost by the additions.
code-asher
force-pushed
the
asher/existing-token
branch
from
890803a to
d353e6a
Compare
fioan89
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the user has already configured the CLI. This will only happen
without user input until the first successful connection.
After that the "use existing token" checkbox must be used to read the
token from the config. It will only be used if it matches the URL.
A secondary effect of the checkbox is that it will not open the browser
window so it can also be used in the case where you already have a token
you want to use but it is not in the CLI config.
Lastly I removed some padding in an attempt to regain the space lost by
the additions.
Closes #166