fix: revert CI change + fix broken tests #4306
Conversation
jsjoeio
added
chore
| - name: Run code-server unit tests | ||
| run: yarn test:unit | ||
| if: success() | ||
|
|
There was a problem hiding this comment.
I'm guessing this was removed by accident but it should be here and we need it before uploading coverage to Codecov (it outputs coverage information).
| - name: Run end-to-end tests | ||
| run: yarn test:unit | ||
|
|
There was a problem hiding this comment.
No need to run unit tests twice
| @@ -162,7 +162,7 @@ export const register = async ( | |||
| } | |||
|
|
|||
| server.on("close", () => { | |||
| vscode.vscodeServer.close() | |||
| vscode?.vscodeServer.close() | |||
There was a problem hiding this comment.
This prevents us trying to call vscodeServer.close() on undefined
| @@ -7,7 +7,7 @@ import * as integration from "../../../utils/integration" | |||
|
|
|||
| const NOT_FOUND = { | |||
| code: 404, | |||
| message: "not found", | |||
| message: "Not Found", | |||
There was a problem hiding this comment.
🛠️ Change needed to make test pass (casing shouldn't matter). I was going to use .toMatch(/string/) but this was quicker
|
✨ Coder.com for PR #4306 deployed! It will be updated on every commit.
|
Codecov Report
@@ Coverage Diff @@
## main #4306 +/- ##
=========================================
+ Coverage 0 68.09% +68.09%
=========================================
Files 0 31 +31
Lines 0 1586 +1586
Branches 0 308 +308
=========================================
+ Hits 0 1080 +1080
- Misses 0 432 +432
- Partials 0 74 +74
Continue to review full report at Codecov.
|
This PR does a few things:
vscodeexists before closingFixes N/A