Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused Lock config #4304

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Remove unused Lock config #4304

merged 1 commit into from
Oct 28, 2021

Conversation

jawnsy
Copy link
Contributor

@jawnsy jawnsy commented Oct 4, 2021

We previously used the Lock app to lock old issues. Since we use Stale to close out old issues, we no longer need this and can remove the config.

@jawnsy jawnsy requested a review from a team as a code owner October 4, 2021 18:10
@jsjoeio jsjoeio added chore Related to maintenance or clean up ci Issues related to ci and removed ci Issues related to ci labels Oct 4, 2021
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jawnsy! 🙌

@github-actions
Copy link

github-actions bot commented Oct 4, 2021

✨ Coder.com for PR #4304 deployed! It will be updated on every commit.

@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #4304 (1b1e356) into main (705e821) will increase coverage by 2.00%.
The diff coverage is n/a.

❗ Current head 1b1e356 differs from pull request most recent head b281463. Consider uploading reports for the commit b281463 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4304      +/-   ##
==========================================
+ Coverage   66.21%   68.22%   +2.00%     
==========================================
  Files          31       31              
  Lines        1619     1586      -33     
  Branches      316      308       -8     
==========================================
+ Hits         1072     1082      +10     
+ Misses        469      430      -39     
+ Partials       78       74       -4     
Impacted Files Coverage Δ
src/node/routes/vscode.ts 37.93% <0.00%> (-12.07%) ⬇️
src/node/routes/login.ts 70.90% <0.00%> (-10.91%) ⬇️
src/node/http.ts 49.25% <0.00%> (-6.43%) ⬇️
src/node/main.ts 45.34% <0.00%> (-2.23%) ⬇️
src/node/routes/index.ts 76.53% <0.00%> (-0.32%) ⬇️
src/node/app.ts 97.91% <0.00%> (-0.09%) ⬇️
src/node/entry.ts 0.00% <0.00%> (ø)
src/common/util.ts 100.00% <0.00%> (ø)
src/node/cli.ts 82.30% <0.00%> (+0.29%) ⬆️
src/node/util.ts 79.77% <0.00%> (+0.54%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4abc525...b281463. Read the comment docs.

@jawnsy
Copy link
Contributor Author

jawnsy commented Oct 8, 2021

@jsjoeio The e2e tests are failing, I think due to the problem you're fixing in #4310, should we force merge this or wait until that problem is fixed? This PR isn't urgent

@jsjoeio
Copy link
Contributor

jsjoeio commented Oct 8, 2021

@jsjoeio The e2e tests are failing, I think due to the problem you're fixing in #4310, should we force merge this or wait until that problem is fixed? This PR isn't urgent

Yeah, I think you're right. I'm very very close to finishing that PR so if you're okay with it, let's wait! I'll ping you here once it's merged and you can rebase and merge this PR

@jsjoeio
Copy link
Contributor

jsjoeio commented Oct 28, 2021

@jawnsy do you mind rebasing this on main? Then CI should pass and we can merge

@jsjoeio
Copy link
Contributor

jsjoeio commented Oct 28, 2021

Argh, sorry, Looks like Asher had to push a fix for the builds here. Just merged. I think you have to rebase one more time 😅

@jawnsy
Copy link
Contributor Author

jawnsy commented Oct 28, 2021

"The beatings will continue until morale improves" -> "The rebases will continue until tests are passing" 😂

@jawnsy
Copy link
Contributor Author

jawnsy commented Oct 28, 2021

Woohoo, everything passing now

@jawnsy jawnsy merged commit aa9755b into main Oct 28, 2021
@jawnsy jawnsy deleted the remove-lock-file branch October 28, 2021 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to maintenance or clean up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants