-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused Lock config #4304
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jawnsy! 🙌
✨ Coder.com for PR #4304 deployed! It will be updated on every commit.
|
51c01ba
to
d820258
Compare
Codecov Report
@@ Coverage Diff @@
## main #4304 +/- ##
==========================================
+ Coverage 66.21% 68.22% +2.00%
==========================================
Files 31 31
Lines 1619 1586 -33
Branches 316 308 -8
==========================================
+ Hits 1072 1082 +10
+ Misses 469 430 -39
+ Partials 78 74 -4
Continue to review full report at Codecov.
|
Yeah, I think you're right. I'm very very close to finishing that PR so if you're okay with it, let's wait! I'll ping you here once it's merged and you can rebase and merge this PR |
d820258
to
5e4de05
Compare
@jawnsy do you mind rebasing this on |
5e4de05
to
3a9bd6b
Compare
Argh, sorry, Looks like Asher had to push a fix for the builds here. Just merged. I think you have to rebase one more time 😅 |
"The beatings will continue until morale improves" -> "The rebases will continue until tests are passing" 😂 |
3a9bd6b
to
b281463
Compare
Woohoo, everything passing now |
We previously used the Lock app to lock old issues. Since we use Stale to close out old issues, we no longer need this and can remove the config.