Skip to content
This repository was archived by the owner on Jan 10, 2023. It is now read-only.

Exit 0 on success for v2 uploading #434

Merged
merged 3 commits into from
May 24, 2021
Merged

Conversation

thomasrockhu
Copy link
Contributor

Purpose

The uploader does not properly handle the server-side response from the v2 uploader. This PR handles the new format
Fixes #415

Notable Changes

None

Tests and Risks?

None

Update the SHA hash files

N/A

@thomasrockhu thomasrockhu requested a review from a team May 23, 2021 13:52
@codecov
Copy link

codecov bot commented May 23, 2021

Codecov Report

Merging #434 (7aadc31) into master (578ee4b) will increase coverage by 0.08%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #434      +/-   ##
==========================================
+ Coverage   45.78%   45.87%   +0.08%     
==========================================
  Files          20       20              
  Lines        2859     2860       +1     
==========================================
+ Hits         1309     1312       +3     
+ Misses       1550     1548       -2     
Flag Coverage Δ
test 39.22% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
env 0.00% <0.00%> (ø)
codecov 67.72% <50.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 578ee4b...7aadc31. Read the comment docs.

@thomasrockhu thomasrockhu merged commit 638717f into master May 24, 2021
@thomasrockhu thomasrockhu deleted the v2-error-on-success branch May 24, 2021 13:54
@blueyed
Copy link
Contributor

blueyed commented May 24, 2021

Thanks!

btw: why does it report the (codecov) patch and project status twice here with the commit (7aadc31) above?

@thomasrockhu
Copy link
Contributor Author

@blueyed one is actually a GitHub status and the other is a GitHub check. I think we hit a race condition and both were sent.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exits non-zero although upload worked with "-X s3" (regression)
3 participants