Skip to content

feat: add multistage Dockerfile for reduced image size. #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 10, 2025

Conversation

geekyharsh05
Copy link
Contributor

@geekyharsh05 geekyharsh05 commented Oct 7, 2024

PR Fixes:

  • Multistage Dockerbuild for reduced image size from 3.5GB to 209MB.
  • Added missing dependencies in package.json for web app.

Resolves #679

Before:

Screenshot 2024-10-08 at 2 56 01 AM

After:

Screenshot 2024-10-08 at 2 42 25 AM

All Services Start Correctly

Screenshot 2024-10-08 at 2 43 52 AM

Landing Page

Screenshot 2024-10-08 at 2 48 24 AM

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue

@geekyharsh05
Copy link
Contributor Author

@hkirat @devsargam Can you please review it?

@geekyharsh05 geekyharsh05 changed the title feat: add Dockerfile for production build and deployment. feat: add multistage Dockerfile for reduced image size for prod. Oct 8, 2024
@geekyharsh05 geekyharsh05 changed the title feat: add multistage Dockerfile for reduced image size for prod. feat: add multistage Dockerfile for reduced image size. Oct 8, 2024
@geekyharsh05
Copy link
Contributor Author

@hkirat @devsargam

@geekyharsh05
Copy link
Contributor Author

@hkirat Can you please review this?

@devsargam devsargam requested a review from Copilot March 9, 2025 10:06
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This pull request introduces a multistage Docker build to drastically reduce the image size and updates the Next.js configuration for handling external images.

  • Refactored Next.js image configuration from static "domains" to dynamic "remotePatterns".
  • Updated docker-compose build configuration to specify the Dockerfile explicitly.

Reviewed Changes

File Description
apps/web/next.config.js Updated image configuration using remotePatterns
docker-compose.yml Modified build configuration to include context and Dockerfile

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

@geekyharsh05
Copy link
Contributor Author

@devsargam Any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Multistage Dockerfile for production
2 participants