Fix service initialization when run in FastBoot server #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e’re running from a FastBoot server
|
@drauschenbach thanks for the PR! It looks like the tests are failing on Travis. I might also recommend a test for the branching logic here, if possible. |
joshsmith
reviewed
Apr 2, 2017
| @@ -2,6 +2,8 @@ | |||
| import Ember from 'ember'; | |||
| import config from '../config/environment'; | |||
|
|
|||
| const isFastBoot = typeof FastBoot !== 'undefined'; | |||
There was a problem hiding this comment.
Can you clarify why const over let in this case?
|
I might also suggest giving a glance to #44. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don’t try and configure Stripe global when it doesn’t exist because w…e’re running from a FastBoot server. Fixes #53