fix: create unique image tags for each test in order to avoid race conditions between tests #74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
This assertion fails because of a race condition between the three tests in this repo.
For example, take a look at this renovate PR:
The manifest produced by each commit in the screenshot are as follows, in order from oldest to newest:
As previously mentioned, there is a race condition between the three tests that get dispatched by this action. They all produce an image tag of
sha-[sha]
. That means that if thetest-docker-build-multi-platform.yml
build finishes before thetest-docker-build.yml
build, the multi-platform manifest will be overwritten by the single-platform image.references
N/A