Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Variable Passthrough & Debug input #62

Merged
merged 5 commits into from
Apr 26, 2024
Merged

Feature: Variable Passthrough & Debug input #62

merged 5 commits into from
Apr 26, 2024

Conversation

Benbentwo
Copy link
Member

what

  • Pass through variables for allow, network, buildkitd-flags, and driver-opts
  • Input for debug which adds a debug flag to buildx

why

  • Debugging and allowing users to fully customize the build setup

references

@Benbentwo Benbentwo changed the title Feature/debug Feature: Variable Passthrough & Debug input Apr 26, 2024
korenyoni
korenyoni approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@korenyoni korenyoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Benbentwo Benbentwo merged commit 51728c1 into main Apr 26, 2024
14 of 16 checks passed
@Benbentwo Benbentwo deleted the feature/debug branch April 26, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korenyoni korenyoni korenyoni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Benbentwo @korenyoni