-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement plan-diff command #1134
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1134 +/- ##
==========================================
+ Coverage 17.44% 18.63% +1.18%
==========================================
Files 170 170
Lines 18764 19224 +460
==========================================
+ Hits 3274 3583 +309
- Misses 14892 15016 +124
- Partials 598 625 +27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Warning This PR exceeds the recommended limit of 1,000 lines.Large PRs are difficult to review and may be rejected due to their size. Please verify that this PR does not address multiple issues. |
Could we add some whitespace and reduce leading whitespace? For example: $ atmos terraform plan-diff myapp -s dev --orig orig.planfile
Diff Output
===========
Plan Differences:
-----------------
~ variables.location.value: Stockholm => New Jersey
~ variables.instance_type.value: t3.micro => t3.large
~ variables.environment.value: development => production
~ planned_values.root_module.resources: (resource changes)
Resources:
----------
Resource: aws_instance.example
~ ami: ami-12345 => ami-67890
~ instance_type: t3.micro => t3.large
~ tags:
- Environment: development => production
- Name: example-stockholm => example-newjersey |
// TestPlanDiffCommandRouting tests that the plan-diff command is correctly routed | ||
// in the ExecuteTerraform function's switch statement. | ||
// | ||
// NOTE: This test will show a linter error when run separately with golangci-lint, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have many lint rules disabled in *_test.go files. Is there another linter we should exclude?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meant to comment, not approve.
what
Create a new command that shows what has changed between two plan files
why
Helps validate that an "approved plan" hasn't changed prior to deployment
example output
todo