Fix OCI Tests & Vendoring #1093
Open
+1,591
−1,219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osterman
changed the title
osterman
reviewed
Feb 26, 2025
.gitignore
Outdated
Comment on lines
40
to
43
|
|
||
| # Ignore components vendored during tests | ||
| tests/fixtures/scenarios/vendor/components/** | ||
| examples/demo-vendoring/components/** |
There was a problem hiding this comment.
Comment for others:
- Files ignored with .gitignore do not appear when querying for untracked files in go-git. While they are not tracked by Git, being listed in .gitignore makes them behave as if they are, preventing their detection as untracked. We rely on untracked files to identify files for cleanup during tests, so this behavior interferes with that process.
|
💥 This pull request now has conflicts. Could you fix it @haitham911? 🙏 |
osterman
reviewed
Feb 28, 2025
tests/fixtures/scenarios/complete/components/terraform/infra/vpc2/component.yaml
Outdated
Show resolved
Hide resolved
|
💥 This pull request now has conflicts. Could you fix it @haitham911? 🙏 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
osterman
reviewed
Feb 28, 2025
osterman
reviewed
Feb 28, 2025
osterman
reviewed
Feb 28, 2025
osterman
reviewed
Mar 10, 2025
| tempDirPermissions = 0o700 | ||
| progressBarWidth = 30 | ||
| maxWidth = 120 | ||
| pkgTypeRemote pkgType = iota |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
ghcr.io.gitignoregenerated files intest/fixturesbecause then we cannot delete untracked files (regression)tests/fixtures/scenarios/vendor/test-components/)tar+gzOCI artifactsartifact-type: application/vnd.atmos.component.terraform.v1+tar+gziptarartifactswhy
references