Skip to content
This repository was archived by the owner on Jan 31, 2021. It is now read-only.

Support Custom VPC Tag Lookup #4

Merged
merged 1 commit into from Jul 20, 2018
Merged

Support Custom VPC Tag Lookup #4

merged 1 commit into from Jul 20, 2018

Conversation

dennybaa
Copy link
Contributor

@dennybaa dennybaa commented Jul 20, 2018 •
edited by osterman
Loading

what

  • Support looking up kops clusters by arbitrary tags and values

why

  • Better way to do it

@osterman osterman requested a review from aknysh July 20, 2018 22:50
@osterman osterman added the enhancement New feature or request label Jul 20, 2018
osterman
osterman suggested changes Jul 20, 2018
View reviewed changes
Copy link

@osterman osterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just one thing: rebuild the README.md using make

Here's how:

make init
make readme/deps
make readme

@dennybaa
Copy link
Contributor Author

well np, rebased.

osterman
osterman reviewed Jul 20, 2018
View reviewed changes
variables.tf Outdated

variable "vpc_tag" {
default = "Name"
description = "Use Name tag to lookup the Kops VPC"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description is now misleading. It should probably say "Tag used to lookup the Kops VPC"

osterman
osterman reviewed Jul 20, 2018
View reviewed changes
variables.tf Outdated

variable "vpc_tag_values" {
default = []
description = "Provide tag value to lookup the Kops VPC"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Tag value used to lookup the Kops VPC"

@dennybaa
Copy link
Contributor Author

Now ok?

osterman
osterman approved these changes Jul 20, 2018
View reviewed changes
Copy link

@osterman osterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! Thanks for the contribution.

@osterman osterman changed the title added custom vpc tag lookup Support Custom VPC Tag Lookup Jul 20, 2018
@osterman osterman merged commit 47f3d21 into cloudposse-archives:master Jul 20, 2018
@dennybaa
Copy link
Contributor Author

@osterman welcome and likewise thank you for useful modules 👍

@osterman
Copy link

@dennybaa my pleasure! stop by our slack team sometime. https://slack.cloudposse.com

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@osterman osterman osterman approved these changes

@aknysh aknysh Awaiting requested review from aknysh

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dennybaa @osterman