Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use broader cookie domain #14

Merged
merged 1 commit into from
Feb 19, 2025
Merged

fix: use broader cookie domain #14

merged 1 commit into from
Feb 19, 2025

Conversation

drewbo
Copy link
Contributor

@drewbo drewbo commented Feb 19, 2025

Changes proposed in this pull request:

  • Use app.cloud.gov as the cookie domain

Security considerations

For testing purposes, we need to use app.cloud.gov as the cookie domain, we should restrict this further in the future

@drewbo drewbo requested a review from a team as a code owner February 19, 2025 15:52
@drewbo drewbo merged commit b768140 into main Feb 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apburnes apburnes apburnes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drewbo @apburnes