Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support multiple dates #160

Merged
merged 5 commits into from
Jan 25, 2025
Merged

Conversation

ctrl-q
Copy link
Contributor

@ctrl-q ctrl-q commented Jan 25, 2025

No description provided.

@muness
Copy link
Member

muness commented Jan 25, 2025

Thanks for this, @ctrl-q : can you add an example of how to use this either in a discussion or in the README? I assume you're using it with Templater?

@ctrl-q
Copy link
Contributor Author

ctrl-q commented Jan 25, 2025

I use it with Full Calendar. I've added an example

@muness
Copy link
Member

muness commented Jan 25, 2025

I've been testing this with a single date for regressions and all events are being excluded. Will update when I figure out why.

@ctrl-q
Copy link
Contributor Author

ctrl-q commented Jan 25, 2025

Ah, isBetween is exclusive. I'll fix that

@ctrl-q
Copy link
Contributor Author

ctrl-q commented Jan 25, 2025

Try again with the latest commit?

@muness muness merged commit 1e1dc55 into cloud-atlas-ai:master Jan 25, 2025
@muness
Copy link
Member

muness commented Jan 25, 2025

Working great, thanks!

@muness
Copy link
Member

muness commented Jan 25, 2025

Gotta get a regression suite in. This recurrence / exclusion / timezone business is gnarly.

@muness muness added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 25, 2025
@muness
Copy link
Member

muness commented Jan 25, 2025

Published along with #161 in https://github.com/cloud-atlas-ai/obsidian-ics/releases/tag/1.9 Thanks much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants