Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dir globbing to discover .clj files #222

Closed
vemv opened this issue Dec 31, 2023 · 0 comments · Fixed by #223
Closed

Use dir globbing to discover .clj files #222

vemv opened this issue Dec 31, 2023 · 0 comments · Fixed by #223
Assignees

Comments

@vemv
Copy link
Member

vemv commented Dec 31, 2023

orchard.namespace can iterate over potentially many, many files (200K+ for a specific user) to determine whether they're .clj files. That's slow enough to cause nrepl timeouts.

Using dir globbing would be faster https://stackoverflow.com/questions/9148528/how-do-i-use-directory-globbing-in-jdk7

See also https://docs.oracle.com/javase/8/docs/api/java/nio/file/FileSystem.html#getPathMatcher-java.lang.String-

@vemv vemv self-assigned this Dec 31, 2023
vemv added a commit that referenced this issue Jan 1, 2024
vemv added a commit that referenced this issue Jan 1, 2024
vemv added a commit that referenced this issue Jan 1, 2024
vemv added a commit that referenced this issue Jan 1, 2024
vemv added a commit that referenced this issue Jan 1, 2024
vemv added a commit that referenced this issue Jan 1, 2024
@vemv vemv closed this as completed in #223 Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant