Fix instrumentation of small map literals. Minor doc updates. #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Map literal instrumentation was relying on some heuristic before. We use Clojures underlying array-map implementation for small map literals and fall back to a sorted order of keys if that is not the case. If this fails as well we simply instrument only the values of the map in the order they appear in a sequential pass.
|
I haven't yet added any tests as I want to get your feedback first. |
FiV0
commented
Feb 5, 2020
| ;; has specified them in that order. If that fails we fall | ||
| ;; back to simply instrumenting the values in the order they | ||
| ;; they appear in the map. | ||
| ;; This depends on Clojure implementation details. |
There was a problem hiding this comment.
More than happy to consider other heuristics or if you think this is a bad idea.
There was a problem hiding this comment.
The idea is reasonable, although this is something we should probably mention in some "Caveats" section of the debugger, so users are not surprised by the behaviour in different scenarios.
There was a problem hiding this comment.
I changed the policy once more. I think the best thing is to do nothing if the ordered keys approach fails. I will also start a caveats section in the cider docs.
FiV0
commented
Feb 5, 2020
bbatsov
reviewed
Feb 5, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Map literal instrumentation was relying on some heuristic before.
We use Clojures underlying array-map implementation for small map
literals and fall back to a sorted order of keys if that is not the
case. If this fails as well we simply instrument only the values of
the map in the order they appear in a sequential pass.
This fixes clojure-emacs/cider#2773 for small maps at least.
Before submitting a PR make sure the following things have been done: