Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make inspect command work on current expression, add inspect-prompt #655

Merged
merged 1 commit into from
Oct 21, 2019

Conversation

yuhan0
Copy link
Contributor

@yuhan0 yuhan0 commented Oct 21, 2019

Credit goes to @alexander-yakushev in #613 :)

  • The commits are consistent with our contribution guidelines
  • You've added tests to cover your change(s)
  • All tests are passing
  • The new code is not generating reflection warnings
  • You've updated the README (if adding/changing middleware)

@yuhan0
Copy link
Contributor Author

yuhan0 commented Oct 21, 2019

Oh, but now the commit message and changelog doesn't line up with the actual change, not sure if I can edit that without overwriting authorship

@bbatsov
Copy link
Member

bbatsov commented Oct 21, 2019

@yuhan0 Just add a second commit that changes this.

Add new command :inspect-prompt with the previous behaviour
@yuhan0
Copy link
Contributor Author

yuhan0 commented Oct 21, 2019

It turns out I could squash the previous commit without overwriting authorship info, learnt something new about Git :)

@bbatsov bbatsov merged commit d345cad into clojure-emacs:master Oct 21, 2019
@bbatsov
Copy link
Member

bbatsov commented Oct 21, 2019

Great! I'll push a new snapshot out.

@alexander-yakushev
Copy link
Member

🥳
Thanks, @yuhan0 and @bbatsov!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants