Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI - Only tag extra docker images on tag refs #2335

Open
wants to merge 5 commits into
base: bfops/align-merge-script
Choose a base branch
from

Conversation

bfops
Copy link
Collaborator

@bfops bfops commented Mar 4, 2025

Description of Changes

Previously, we would create an extra docker image for every git ref that was pushed. Now, we only do it for tags.

We had intended to remove the docker tags for git branches a long time ago, because it was cumbersome to map between "we're using the docker image of $BRANCH" to which exact commit was deployed. However, this merge-docker-images.sh script slipped through the cracks, so it was still creating docker tags corresponding to git branches.

API and ABI breaking changes

No code changes.

Expected complexity level and risk

1

Testing

  • When I make the CI run on this branch, we successfully get all the sha docker tags (platform-specified, unified) but NOT a docker tag for the branch name

@bfops bfops requested a review from jdetter March 4, 2025 00:09
@bfops bfops marked this pull request as ready for review March 4, 2025 05:58
@bfops bfops added release-any To be landed in any release window no runtime change This change does not affect the final binaries labels Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no runtime change This change does not affect the final binaries release-any To be landed in any release window
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant