Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .cargo/config.toml to spacetime init Rust project with default target to wasm #2328

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add .cargo/config.toml to spacetime init Rust project with default target to wasm #2328

wants to merge 3 commits into from
+15 −0

Conversation

mamcx
Copy link
Contributor

@mamcx mamcx commented Feb 28, 2025 •
edited
Loading

Description of Changes

Closes #1730.

Now when spacetimedb-cli init --lang rust it will create the config that pin target = "wasm32-unknown-unknown".

Also, I added the config to all the modules for completion.

API and ABI breaking changes

1

It actually fix the generated project.

Expected complexity level and risk

1

Testing

  • Confirm the issue calling manually cargo build before and after this patch.

@mamcx mamcx added release-any To be landed in any release window bugfix Fixes something that was expected to work differently labels Feb 28, 2025
@mamcx mamcx requested a review from jdetter February 28, 2025 20:46
@mamcx mamcx self-assigned this Feb 28, 2025
bfops
bfops approved these changes Mar 6, 2025
View reviewed changes
Copy link
Collaborator

@bfops bfops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me

@bfops
Copy link
Collaborator

bfops commented Mar 6, 2025

(Except that this is failing Internal tests)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfops bfops bfops approved these changes

@jdetter jdetter Awaiting requested review from jdetter jdetter is a code owner

@gefjon gefjon Awaiting requested review from gefjon gefjon is a code owner

@cloutiertyler cloutiertyler Awaiting requested review from cloutiertyler cloutiertyler is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@mamcx mamcx

Labels
bugfix Fixes something that was expected to work differently release-any To be landed in any release window
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add .cargo/config.toml to spacetime init Rust project with default target
2 participants
@mamcx @bfops