Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment on Time Stamp Counter (TSC) for profiling with tracy #2304

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

joshua-spacetime
Copy link
Collaborator

@joshua-spacetime joshua-spacetime commented Feb 24, 2025

Description of Changes

See code comment.

API and ABI breaking changes

None

Expected complexity level and risk

1

Testing

This patch does not include any actual code changes. Just a comment and one line of commented out code. The commented out code line was tested manually be spinning up the docker dev env.

Copy link
Collaborator

@jdetter jdetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit but otherwise LGTM

@joshua-spacetime joshua-spacetime force-pushed the joshua/tracy-invariant-check branch from bed3cff to e3163fb Compare February 25, 2025 04:53
@joshua-spacetime joshua-spacetime changed the title Set TRACY_NO_INVARIANT_CHECK in dev environment Add comment on Time Stamp Counter (TSC) for profiling with tracy Feb 25, 2025
@joshua-spacetime joshua-spacetime force-pushed the joshua/tracy-invariant-check branch from e3163fb to 13bbd29 Compare February 25, 2025 17:10
@joshua-spacetime joshua-spacetime added this pull request to the merge queue Feb 25, 2025
Merged via the queue into master with commit 172c060 Feb 25, 2025
15 checks passed
@joshua-spacetime joshua-spacetime deleted the joshua/tracy-invariant-check branch February 25, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants