MutTxId::update: consider deleted commited row when replacing tx row
#2302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gefjon
approved these changes
Feb 24, 2025
Co-authored-by: Phoebe Goldman <[email protected]> Signed-off-by: Mazdak Farrokhzad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fixes #2296.
In
MutTxId::update: If there was a deleted committed row (row), this fact is recorded. Later, when updating arow_prime, resident in the tx state and sharing akeywithrow, ifrow_primeit's to be replaced withrow's contents, we revert the insertion of the and instead un-deleterow.API and ABI breaking changes
None
Expected complexity level and risk
2?
Testing
test_update_brings_back_deleted_commit_row_repro_2296is added.updatehost call produces TXes containing no-op insert/delete pairs in sequences of delete->insert->update #2296 (comment) was tested manually against the new impl and the database was successfully restarted.