Add support for LIMIT #2279
Merged
Add support for LIMIT #2279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note, internal tests will fail due to a new dependency on |
joshua-spacetime
force-pushed
the
joshua/sql-limit
branch
from
e21c4fa to
c136edd
Compare
joshua-spacetime
force-pushed
the
joshua/sql-limit
branch
from
c136edd to
aa37c5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Adds LIMIT to the sql api.
API and ABI breaking changes
None
Expected complexity level and risk
2
Changes include:
Testing
Additional tests for both typing and executing a
LIMITclause