Add metrics for index inserts and deletes #2236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-spacetime
approved these changes
Feb 10, 2025
We might need/want to add that in the future, but I don't think it's worth the extra changes to add right now. Overall it is less important that the bytes written metric, since indexes are totally in memory. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This adds metrics for index insertions and deletions. It relies on the fact that we don't have sparse indexes.
Note that we don't count index insertions for newly added indexes, which we may want to add in the future.
Expected complexity level and risk
1
Testing
Not tested, but seems very low risk, since it mostly uses the row insertion tracking.