Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add direct indices, except for in datastore & C# #2205

Merged
merged 8 commits into from
Feb 6, 2025

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Feb 4, 2025

Description of Changes

Adds the schema and rust module side support for direct indices.
What remains to be done after this PR is to:

  • hook up the datastore support for the index.
  • add C# module support.

API and ABI breaking changes

None

Expected complexity level and risk

3, touches a lot of places.

Testing

Some new tests are added for the schema and existing tests are amended.

Copy link
Contributor

@kazimuth kazimuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the schema stuff looks good.

Copy link
Collaborator

@coolreader18 coolreader18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

macro/bindings stuff generally LGTM; UniqueColumn will probably need an extra bound in the future in order to tell it whether to use btree or direct, but that's fine.

@Centril Centril force-pushed the centril/direct-index branch from 086b62f to 70bdde4 Compare February 5, 2025 16:16
@Centril Centril force-pushed the centril/direct-index branch from ef7ddf6 to 5aae1d8 Compare February 5, 2025 23:26
@Centril Centril enabled auto-merge February 6, 2025 00:40
@Centril Centril added this pull request to the merge queue Feb 6, 2025
Merged via the queue into master with commit 1a3f3af Feb 6, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants