Update sql literals to match spec #2196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-spacetime
force-pushed
the
joshua/sql-scientific-notation
branch
from
308c192 to
1bb8460
Compare
mamcx
reviewed
Jan 31, 2025
joshua-spacetime
force-pushed
the
joshua/dml
branch
from
1cd7196 to
3f57d22
Compare
joshua-spacetime
force-pushed
the
joshua/sql-scientific-notation
branch
from
1bb8460 to
6a4cd83
Compare
mamcx
reviewed
Feb 4, 2025
mamcx
reviewed
Feb 4, 2025
joshua-spacetime
changed the title
joshua-spacetime
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Parses literals in accordance with the sql spec. Specifically it adds support for scientific notation.
API and ABI breaking changes
None
Expected complexity level and risk
2
Adds a dependency on
BigDecimalboth for parsing scientific notation as well as for parsing 128 and 256 bit integer literals.Testing
Added new parsing and type checking test cases