Make check_and_insert & find_old_row and friends do less checks
#2192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
force-pushed
the
centril/unchecked-index-insertion
branch
from
7b225a8 to
4e221d5
Compare
gefjon
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
In general, what this PR achieves is to remove various bounds checks and type checks in relation to index lookups and insertions.
This shows up in flamegraphs as getting rid of a
ReadColumn::read_columnand shrinking the share ofRowRef::{project -> project_unchecked}as well as reducing the self-time ofconfirm_insertion,values_in_range.API and ABI breaking changes
None.
Expected complexity level and risk
3, plenty of
unsafewas added but the proofs/requirements are mostly boring plumbing. Still, it is unfortunate :(Testing
Existing tests have been amended.