Remove janky schema from http API

[coolreader18]

Description of Changes

Get rid of the weird stuff in describe and just return a RawModuleDef.

Expected complexity level and risk

2 - changes api a decent amount but only to return an already well-established format.

Testing

• Smoketests cover this wrt to CLI changes.

[coolreader18]

I semi-rewrote the invalid_arguments stuff because it was interacting with the api through serde_json::Values instead of ModuleDef, and it was much easier to just make it use ModuleDef than to keep the weird stuff.

[bfops]

I don't think I'm equipped to review the non-CLI "meat" of this PR, sorry.

[bfops]

Question about testing - Did this PR change the expected output format of spacetime describe at all? The smoketests just seem to test that the CLI exits successfully, but I don't see, like, snapshot tests or anything. I don't specifically think that we need them, just trying to understand the expected impact here.

Edit: Yeah I think on further review of the changes to spacetime call especially, it would be good to have some clarity on what the final output looks like now and making sure that it still looks reasonable for users.

[coolreader18]

I don't think there's really any use case for spacetime describe atm besides some sort of scripting. Ideally I think its default behavior would be to show a nice human-readable description of the module or the selected item. Maybe its current behavior should be put behind a --json flag, or it should just be removed entirely until it has a better spec?

[bfops]

I don't think there's really any use case for spacetime describe atm besides some sort of scripting. Ideally I think its default behavior would be to show a nice human-readable description of the module or the selected item. Maybe its current behavior should be put behind a --json flag, or it should just be removed entirely until it has a better spec?

Yeah I don't think we particularly need to preserve the old output, but I do think we want to make sure that describe and call still have reasonable-looking outputs.

I do think we've told some folks with larger DBs to inspect them via describe, so I don't think we should remove it entirely. We're going to mark it as "unstable" for 1.0 though, so we can totally keep changing it / breaking it.

[cloutiertyler]

This all looks quite good to me. It's definitely an improvement. I ran it on quickstart-chat

{
  "typespace": {
    "types": [
      {
        "Product": {
          "elements": [
            {
              "name": {
                "some": "sender"
              },
              "algebraic_type": {
                "Product": {
                  "elements": [
                    {
                      "name": {
                        "some": "__identity__"
                      },
                      "algebraic_type": {
                        "U256": []
                      }
                    }
                  ]
                }
              }
            },
            {
              "name": {
                "some": "sent"
              },
              "algebraic_type": {
                "Product": {
                  "elements": [
                    {
                      "name": {
                        "some": "__timestamp_micros_since_unix_epoch__"
                      },
                      "algebraic_type": {
                        "I64": []
                      }
                    }
                  ]
                }
              }
            },
            {
              "name": {
                "some": "text"
              },
              "algebraic_type": {
                "String": []
              }
            }
          ]
        }
      },
      {
        "Product": {
          "elements": [
            {
              "name": {
                "some": "identity"
              },
              "algebraic_type": {
                "Product": {
                  "elements": [
                    {
                      "name": {
                        "some": "__identity__"
                      },
                      "algebraic_type": {
                        "U256": []
                      }
                    }
                  ]
                }
              }
            },
            {
              "name": {
                "some": "name"
              },
              "algebraic_type": {
                "Sum": {
                  "variants": [
                    {
                      "name": {
                        "some": "some"
                      },
                      "algebraic_type": {
                        "String": []
                      }
                    },
                    {
                      "name": {
                        "some": "none"
                      },
                      "algebraic_type": {
                        "Product": {
                          "elements": []
                        }
                      }
                    }
                  ]
                }
              }
            },
            {
              "name": {
                "some": "online"
              },
              "algebraic_type": {
                "Bool": []
              }
            }
          ]
        }
      }
    ]
  },
  "tables": [
    {
      "name": "message",
      "product_type_ref": 0,
      "primary_key": [],
      "indexes": [],
      "constraints": [],
      "sequences": [],
      "schedule": {
        "none": []
      },
      "table_type": {
        "User": []
      },
      "table_access": {
        "Public": []
      }
    },
    {
      "name": "user",
      "product_type_ref": 1,
      "primary_key": [
        0
      ],
      "indexes": [
        {
          "name": {
            "some": "user_identity_idx_btree"
          },
          "accessor_name": {
            "some": "identity"
          },
          "algorithm": {
            "BTree": [
              0
            ]
          }
        }
      ],
      "constraints": [
        {
          "name": {
            "some": "user_identity_key"
          },
          "data": {
            "Unique": {
              "columns": [
                0
              ]
            }
          }
        }
      ],
      "sequences": [],
      "schedule": {
        "none": []
      },
      "table_type": {
        "User": []
      },
      "table_access": {
        "Public": []
      }
    }
  ],
  "reducers": [
    {
      "name": "identity_connected",
      "params": {
        "elements": []
      },
      "lifecycle": {
        "some": {
          "OnConnect": []
        }
      }
    },
    {
      "name": "identity_disconnected",
      "params": {
        "elements": []
      },
      "lifecycle": {
        "some": {
          "OnDisconnect": []
        }
      }
    },
    {
      "name": "init",
      "params": {
        "elements": []
      },
      "lifecycle": {
        "some": {
          "Init": []
        }
      }
    },
    {
      "name": "send_message",
      "params": {
        "elements": [
          {
            "name": {
              "some": "text"
            },
            "algebraic_type": {
              "String": []
            }
          }
        ]
      },
      "lifecycle": {
        "none": []
      }
    },
    {
      "name": "set_name",
      "params": {
        "elements": [
          {
            "name": {
              "some": "name"
            },
            "algebraic_type": {
              "String": []
            }
          }
        ]
      },
      "lifecycle": {
        "none": []
      }
    }
  ],
  "types": [
    {
      "name": {
        "scope": [],
        "name": "Message"
      },
      "ty": 0,
      "custom_ordering": true
    },
    {
      "name": {
        "scope": [],
        "name": "User"
      },
      "ty": 1,
      "custom_ordering": true
    }
  ],
  "misc_exports": [],
  "row_level_security": []
}