Fix ScheduleAt in C# #2163
Merged
Fix ScheduleAt in C# #2163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RReverser
reviewed
Jan 23, 2025
RReverser
reviewed
Jan 23, 2025
RReverser
reviewed
Jan 23, 2025
Purge console logging Update crates/bindings-csharp/BSATN.Runtime/Builtins.cs Co-authored-by: Ingvar Stepanyan <[email protected]> Signed-off-by: james gilles <[email protected]> Revert struct removal Remove space
kazimuth
force-pushed
the
jgilles/fix-cs-timestamps
branch
from
adb59bf to
6c11592
Compare
kazimuth
commented
Jan 23, 2025
RReverser
approved these changes
Jan 23, 2025
gefjon
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fix the implementation of C# timestamps. While addressing issues on blackholio I noticed these were incorrect. The specific issue was a missed subtraction of DateTimeOffset.UnixEpoch when converting from DateTimeOffset to milliseconds.
A fix is needed if the C# server version of Blackholio is to work.
#1836 is a larger change that will rework Timestamp in C#, that will want to be rebased onto this.
API and ABI breaking changes
Added APIs in the C# SDK.
Expected complexity level and risk
0
Testing
Added a unit test.